Refactor tests

2020-11-03 15:37:45 +08:00
parent 265cf4c580
commit 848f8ed21e
66 changed files with 51 additions and 54 deletions
--- a/tests/assets/StarWars3.wav
+++ b/tests/assets/StarWars3.wav
--- a/tests/assets/flame.avi
+++ b/tests/assets/flame.avi
--- a/tests/assets/triangle/audio.ogg
+++ b/tests/assets/triangle/audio.ogg
--- a/tests/assets/triangle/tmp.000.png
+++ b/tests/assets/triangle/tmp.000.png
--- a/tests/assets/triangle/tmp.001.png
+++ b/tests/assets/triangle/tmp.001.png
--- a/tests/assets/triangle/tmp.002.png
+++ b/tests/assets/triangle/tmp.002.png
--- a/tests/assets/triangle/tmp.003.png
+++ b/tests/assets/triangle/tmp.003.png
--- a/tests/assets/triangle/tmp.004.png
+++ b/tests/assets/triangle/tmp.004.png
--- a/tests/assets/triangle/tmp.005.png
+++ b/tests/assets/triangle/tmp.005.png
--- a/tests/assets/triangle/tmp.006.png
+++ b/tests/assets/triangle/tmp.006.png
--- a/tests/assets/triangle/tmp.007.png
+++ b/tests/assets/triangle/tmp.007.png
--- a/tests/assets/triangle/tmp.008.png
+++ b/tests/assets/triangle/tmp.008.png
--- a/tests/assets/triangle/tmp.009.png
+++ b/tests/assets/triangle/tmp.009.png
--- a/tests/assets/triangle/tmp.010.png
+++ b/tests/assets/triangle/tmp.010.png
--- a/tests/assets/triangle/tmp.011.png
+++ b/tests/assets/triangle/tmp.011.png
--- a/tests/assets/triangle/tmp.012.png
+++ b/tests/assets/triangle/tmp.012.png
--- a/tests/assets/triangle/tmp.013.png
+++ b/tests/assets/triangle/tmp.013.png
--- a/tests/assets/triangle/tmp.014.png
+++ b/tests/assets/triangle/tmp.014.png
--- a/tests/assets/triangle/tmp.015.png
+++ b/tests/assets/triangle/tmp.015.png
--- a/tests/assets/triangle/tmp.016.png
+++ b/tests/assets/triangle/tmp.016.png
--- a/tests/assets/triangle/tmp.017.png
+++ b/tests/assets/triangle/tmp.017.png
--- a/tests/assets/triangle/tmp.018.png
+++ b/tests/assets/triangle/tmp.018.png
--- a/tests/assets/triangle/tmp.019.png
+++ b/tests/assets/triangle/tmp.019.png
--- a/tests/assets/triangle/tmp.020.png
+++ b/tests/assets/triangle/tmp.020.png
--- a/tests/assets/triangle/tmp.021.png
+++ b/tests/assets/triangle/tmp.021.png
--- a/tests/assets/triangle/tmp.022.png
+++ b/tests/assets/triangle/tmp.022.png
--- a/tests/assets/triangle/tmp.023.png
+++ b/tests/assets/triangle/tmp.023.png
--- a/tests/assets/triangle/tmp.024.png
+++ b/tests/assets/triangle/tmp.024.png
--- a/tests/assets/triangle/tmp.025.png
+++ b/tests/assets/triangle/tmp.025.png
--- a/tests/assets/triangle/tmp.026.png
+++ b/tests/assets/triangle/tmp.026.png
--- a/tests/assets/triangle/tmp.027.png
+++ b/tests/assets/triangle/tmp.027.png
--- a/tests/assets/triangle/tmp.028.png
+++ b/tests/assets/triangle/tmp.028.png
--- a/tests/assets/triangle/tmp.029.png
+++ b/tests/assets/triangle/tmp.029.png
--- a/tests/assets/triangle/tmp.030.png
+++ b/tests/assets/triangle/tmp.030.png
--- a/tests/assets/triangle/tmp.031.png
+++ b/tests/assets/triangle/tmp.031.png
--- a/tests/assets/triangle/tmp.032.png
+++ b/tests/assets/triangle/tmp.032.png
--- a/tests/assets/triangle/tmp.033.png
+++ b/tests/assets/triangle/tmp.033.png
--- a/tests/assets/triangle/tmp.034.png
+++ b/tests/assets/triangle/tmp.034.png
--- a/tests/assets/triangle/tmp.035.png
+++ b/tests/assets/triangle/tmp.035.png
--- a/tests/assets/triangle/tmp.036.png
+++ b/tests/assets/triangle/tmp.036.png
--- a/tests/assets/triangle/tmp.037.png
+++ b/tests/assets/triangle/tmp.037.png
--- a/tests/assets/triangle/tmp.038.png
+++ b/tests/assets/triangle/tmp.038.png
--- a/tests/assets/triangle/tmp.039.png
+++ b/tests/assets/triangle/tmp.039.png
--- a/tests/assets/triangle/tmp.040.png
+++ b/tests/assets/triangle/tmp.040.png
--- a/tests/assets/triangle/tmp.041.png
+++ b/tests/assets/triangle/tmp.041.png
--- a/tests/assets/triangle/tmp.042.png
+++ b/tests/assets/triangle/tmp.042.png
--- a/tests/assets/triangle/tmp.043.png
+++ b/tests/assets/triangle/tmp.043.png
--- a/tests/assets/triangle/tmp.044.png
+++ b/tests/assets/triangle/tmp.044.png
--- a/tests/assets/triangle/tmp.045.png
+++ b/tests/assets/triangle/tmp.045.png
--- a/tests/assets/triangle/tmp.046.png
+++ b/tests/assets/triangle/tmp.046.png
--- a/tests/assets/triangle/tmp.047.png
+++ b/tests/assets/triangle/tmp.047.png
--- a/tests/assets/triangle/tmp.048.png
+++ b/tests/assets/triangle/tmp.048.png
--- a/tests/assets/triangle/tmp.049.png
+++ b/tests/assets/triangle/tmp.049.png
--- a/tests/assets/triangle/tmp.050.png
+++ b/tests/assets/triangle/tmp.050.png
--- a/tests/assets/triangle/tmp.051.png
+++ b/tests/assets/triangle/tmp.051.png
--- a/tests/assets/triangle/tmp.052.png
+++ b/tests/assets/triangle/tmp.052.png
--- a/tests/assets/triangle/tmp.053.png
+++ b/tests/assets/triangle/tmp.053.png
--- a/tests/assets/triangle/tmp.054.png
+++ b/tests/assets/triangle/tmp.054.png
--- a/tests/assets/triangle/tmp.055.png
+++ b/tests/assets/triangle/tmp.055.png
--- a/tests/assets/triangle/tmp.056.png
+++ b/tests/assets/triangle/tmp.056.png
--- a/tests/assets/triangle/tmp.057.png
+++ b/tests/assets/triangle/tmp.057.png
--- a/tests/assets/triangle/tmp.058.png
+++ b/tests/assets/triangle/tmp.058.png
--- a/tests/assets/triangle/tmp.059.png
+++ b/tests/assets/triangle/tmp.059.png
--- a/tests/constants.js
+++ b/tests/constants.js
@@ -1,8 +1,7 @@
 const TIMEOUT = 60000;
-const BASE_URL = 'http://localhost:3000/tests/assets';
 const IS_BROWSER = typeof window !== 'undefined' && typeof window.document !== 'undefined';
 const OPTIONS = {
-  corePath: 'http://localhost:3000/node_modules/@ffmpeg/core/ffmpeg-core.js',
+  corePath: IS_BROWSER ? 'http://localhost:3000/node_modules/@ffmpeg/core/dist/ffmpeg-core.js' : '@ffmpeg/core',
 };
 const FLAME_MP4_LENGTH = 100374;
 const META_FLAME_MP4_LENGTH = 100408;
@@ -11,7 +10,6 @@ const META_FLAME_MP4_LENGTH_NO_SPACE = 100404;
 if (typeof module !== 'undefined') {
  module.exports = {
    TIMEOUT,
-    BASE_URL,
    IS_BROWSER,
    OPTIONS,
    FLAME_MP4_LENGTH,
--- a/tests/ffmpeg.test.html
+++ b/tests/ffmpeg.test.html
@@ -8,12 +8,13 @@
 <body>
  <div id="mocha"></div>
  <script src="../node_modules/mocha/mocha.js"></script>
-  <script src="../node_modules/expect.js/index.js"></script>
+  <script src="../node_modules/chai/chai.js"></script>
  <script src="../dist/ffmpeg.dev.js"></script>
  <script src="./constants.js"></script>
  <script>mocha.setup('bdd');</script>
  <script src="./ffmpeg.test.js"></script>
  <script>
+    window.expect = chai.expect;
    mocha.run();
  </script>
 </body>
--- a/tests/ffmpeg.test.js
+++ b/tests/ffmpeg.test.js
@@ -1,62 +1,60 @@
 const { createFFmpeg } = FFmpeg;
-const ffmpeg = createFFmpeg(OPTIONS);

-before(async function cb() {
-  this.timeout(0);
-  await ffmpeg.load();
+describe('load()', () => {
+  it('should throw error when not called before FS() and run()', () => {
+    const ffmpeg = createFFmpeg(OPTIONS);
+    expect(() => ffmpeg.FS('readdir', 'dummy')).to.throw();
+    expect(() => ffmpeg.run('-h')).to.throw();
+  });
+
+  it('should throw error when running load() more than once', async () => {
+    const ffmpeg = createFFmpeg(OPTIONS);
+    await ffmpeg.load();
+    try {
+      await ffmpeg.load();
+    } catch (e) {
+      expect(e).to.be.an('Error');
+    }
+  }).timeout(TIMEOUT);
 });

-describe('transcode()', () => {
-  describe('should transcode different format', () => {
-    [1, 2, 4].forEach((n) => {
-      [
-        { from: 'flame.avi', to: 'flame.mp4' },
-        { from: 'flame.avi', to: 'flame.webm' },
-        { from: 'StarWars3.wav', to: 'StarWars3.mp3' },
-      ].forEach(({ from, to }) => (
-        it(`transcode ${from} to ${to} (${n} threads)`, async () => {
-          await ffmpeg.write(from, `${BASE_URL}/${from}`);
-          await ffmpeg.transcode(from, to, `-threads ${n}`);
-          const data = ffmpeg.read(to);
-          ffmpeg.remove(to);
-          expect(data.length).not.to.be(0);
-        }).timeout(TIMEOUT)
-      ));
-    });
-  });
+describe('isLoaded()', () => {
+  it('should return true when loaded', async () => {
+    const ffmpeg = createFFmpeg(OPTIONS);
+    await ffmpeg.load();
+    expect(ffmpeg.isLoaded()).to.equal(true);
+  }).timeout(TIMEOUT);
 });

 describe('run()', () => {
-  describe('should run a command with quoted parameters at start no spaces', () => {
-    ['flame.avi'].forEach((name) => (
-      it(`run ${name}`, async () => {
-        await ffmpeg.write(name, `${BASE_URL}/${name}`);
-        await ffmpeg.run(`-y -i ${name} -metadata 'title="test"' output.mp4`);
-        const data = ffmpeg.read('output.mp4');
-        expect(data.length).to.be(META_FLAME_MP4_LENGTH_NO_SPACE);
-      }).timeout(TIMEOUT)
-    ));
+  it('should not allow to run two command at the same time', async () => {
+    const ffmpeg = createFFmpeg(OPTIONS);
+    await ffmpeg.load();
+    ffmpeg.run('-h');
+    setTimeout(() => {
+      try {
+        ffmpeg.run('-h');
+      } catch (e) {
+        expect(e).to.be.an(Error);
+      }
+    }, 500);
+  }).timeout(TIMEOUT);
+});
+
+describe('FS()', () => {
+  const ffmpeg = createFFmpeg(OPTIONS);
+  before(async function cb() {
+    this.timeout(0);
+    await ffmpeg.load();
  });

-  describe('should run a command with quoted parameters at start and a space in between', () => {
-    ['flame.avi'].forEach((name) => (
-      it(`run ${name}`, async () => {
-        await ffmpeg.write(name, `${BASE_URL}/${name}`);
-        await ffmpeg.run(`-y -i ${name} -metadata 'title="my title"' output.mp4`);
-        const data = ffmpeg.read('output.mp4');
-        expect(data.length).to.be(META_FLAME_MP4_LENGTH);
-      }).timeout(TIMEOUT)
-    ));
+  it('should throw error when readdir for invalid path ', () => {
+    expect(() => ffmpeg.FS('readdir', '/invalid')).to.throw(/readdir/);
  });
-
-  describe('should run a command with name quoted parameters and a space in between', () => {
-    ['flame.avi'].forEach((name) => (
-      it(`run ${name}`, async () => {
-        await ffmpeg.write(name, `${BASE_URL}/${name}`);
-        await ffmpeg.run(`-y -i ${name} -metadata title="my title" output.mp4`);
-        const data = ffmpeg.read('output.mp4');
-        expect(data.length).to.be(META_FLAME_MP4_LENGTH);
-      }).timeout(TIMEOUT)
-    ));
+  it('should throw error when readFile for invalid path ', () => {
+    expect(() => ffmpeg.FS('readFile', '/invalid')).to.throw(/readFile/);
+  });
+  it('should throw an default error ', () => {
+    expect(() => ffmpeg.FS('unlink', '/invalid')).to.throw(/Oops/);
  });
 });